feat: Handling of low funds cases in the UI (part-2) #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d integrate with low funds alert
…ok for improved readability and maintainability
Base automatically changed from
mohan/handling-low-fees
to
feature/agent-memeooorr
December 11, 2024 13:02
…k and remove useChainDetails
truemiller
approved these changes
Dec 11, 2024
| {!hasEnoughEthForInitialFunding && ( | ||
| <div> | ||
| {UNICODE_SYMBOLS.BULLET}{' '} | ||
| <Text strong>{nativeTokenRequired}</Text> - for trading. |
There was a problem hiding this comment.
it's "for trading" only for trader agent I presume. should we have different text based on agent type?
There was a problem hiding this comment.
I’m not sure, but I’ll ask Iason/Roman about it.
|
|
||
| const { selectedAgentConfig } = useServices(); | ||
| const { evmHomeChainId: homeChainId } = selectedAgentConfig; | ||
| const nativeTokenSymbol = getNativeTokenSymbol(homeChainId); |
There was a problem hiding this comment.
tiny, could move this to nativeTokenRequired useMemo
There was a problem hiding this comment.
yup, I will update this in the next PR.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Design
Changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply